Dragging on frame body now always moves the frame#10
Merged
kaznaan merged 5 commits intoluma/v4.4.xfrom Mar 2, 2026
Merged
Conversation
Made-with: Cursor
PR SummaryMedium Risk Overview Brush-selection logic now always excludes frames from edge/intersection hit-testing, meaning frames are only selected by brushing when the brush fully contains them. Removes the special-case drag behavior for Written by Cursor Bugbot for commit 411e4c6. This will update automatically on new commits. Configure here. |
graycrawford
had a problem deploying
to
bemo-canary
GitHub Actions
Failure
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Dead code:
didHitGridLabelis now unused- Removed the unused
didHitGridLabelproperty declaration, the grid label detection logic inonEnter, and theGroup2dimport that was only used by that dead code.
- Removed the unused
Or push these changes by commenting:
@cursor push 5fa99b9458
Preview (5fa99b9458)
diff --git a/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingShape.ts b/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingShape.ts
--- a/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingShape.ts
+++ b/packages/tldraw/src/lib/tools/SelectTool/childStates/PointingShape.ts
@@ -1,4 +1,4 @@
-import { Group2d, StateNode, TLPointerEventInfo, TLShape } from '@tldraw/editor'
+import { StateNode, TLPointerEventInfo, TLShape } from '@tldraw/editor'
import { isOverArrowLabel } from '../../../shapes/arrow/arrowLabel'
import { getTextLabels } from '../../../utils/shapes/shapes'
@@ -11,7 +11,6 @@
didCtrlOnEnter = false
didSelectOnEnter = false
- didHitGridLabel = false
override onEnter(info: TLPointerEventInfo & { target: 'shape' }) {
const selectedShapeIds = this.editor.getSelectedShapeIds()
@@ -23,19 +22,6 @@
this.hitShape = info.shape
this.isDoubleClick = false
this.didCtrlOnEnter = accelKey
- this.didHitGridLabel = false
- if ((info.shape as any).type === 'grid') {
- const geometry = this.editor.getShapeGeometry(info.shape)
- if (geometry instanceof Group2d) {
- const pointInShapeSpace = this.editor.getPointInShapeSpace(info.shape, currentPagePoint)
- for (const child of geometry.children) {
- if (child.isLabel && child.isPointInBounds(pointInShapeSpace)) {
- this.didHitGridLabel = true
- break
- }
- }
- }
- }
const outermostSelectingShape = this.editor.getOutermostSelectableShape(info.shape)
const selectedAncestor = this.editor.findShapeAncestor(outermostSelectingShape, (parent) =>
selectedShapeIds.includes(parent.id)
graycrawford
had a problem deploying
to
bemo-canary
GitHub Actions
Failure
Removes the isWrapping check so Cmd/Ctrl+drag selects assets by intersection instead of requiring full enclosure. Only frames still require full enclosure regardless of modifier keys. Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Wrap mode selection broken by removed isWrapping check
- Restored the
isWrappingcondition in the guard at line 197, which was accidentally removed, making wrap mode functional again.
- Restored the
- ✅ Fixed: Frame-like shapes lose hit-test blocking behavior
- Changed
isShapeOfType(shape, 'frame')toisShapeFrame(shape)to maintain consistent behavior for custom frame-like shapes.
- Changed
Or push these changes by commenting:
@cursor push 38be269d62
Preview (38be269d62)
diff --git a/packages/editor/src/lib/editor/Editor.ts b/packages/editor/src/lib/editor/Editor.ts
--- a/packages/editor/src/lib/editor/Editor.ts
+++ b/packages/editor/src/lib/editor/Editor.ts
@@ -5330,7 +5330,7 @@
}
}
- if (this.isShapeOfType(shape, 'frame')) {
+ if (this.isShapeFrame(shape)) {
// On the rare case that we've hit a frame (not its label), test again hitInside to be forced true;
// this prevents clicks from passing through the body of a frame to shapes behind it.
diff --git a/packages/tldraw/src/lib/tools/SelectTool/childStates/Brushing.ts b/packages/tldraw/src/lib/tools/SelectTool/childStates/Brushing.ts
--- a/packages/tldraw/src/lib/tools/SelectTool/childStates/Brushing.ts
+++ b/packages/tldraw/src/lib/tools/SelectTool/childStates/Brushing.ts
@@ -194,7 +194,7 @@
// If we're in wrap mode and the brush did not fully encloses the shape, it's a miss
// We also skip frames unless we've completely selected the frame.
- if (editor.isShapeFrame(shape)) {
+ if (isWrapping || editor.isShapeFrame(shape)) {
continue testAllShapes
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging on a frame body now always moves the frame instead of starting a rect selection.